12571 add endpoint to delete layout set #12598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/process
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12598 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 1289 1290 +1
Lines 18523 18534 +11
Branches 2269 2269
=======================================
+ Hits 16430 16441 +11
Misses 1835 1835
Partials 258 258 ☔ View full report in Codecov by Sentry. |
standeren
force-pushed
the
12571-add-endpoint-to-delete-layout-set
branch
from
cf5078e to
c8f7e24
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
backend/tests/Designer.Tests/Controllers/AppDevelopmentController/DeleteLayoutSetTests.cs
Fixed
Show fixed
Hide fixed
backend/tests/Designer.Tests/Controllers/AppDevelopmentController/DeleteLayoutSetTests.cs
Fixed
Show resolved
Hide resolved
standeren
force-pushed
the
12571-add-endpoint-to-delete-layout-set
branch
2 times, most recently
from
fc429e9 to
4ff6fd1
Compare
mirkoSekulic
approved these changes
Apr 4, 2024
|
The issue is that we have 2 LayoutSets models in our solution now. Altinn.Studio.Designer.Models.LayoutSets and |
Hm, okey, where is the latter used? And do we need both? 🤔 |
mirkoSekulic
approved these changes
Apr 4, 2024
…e25e-4f3d-baf3-429eef2b404f.xml
standeren
force-pushed
the
12571-add-endpoint-to-delete-layout-set
branch
from
c39caf2 to
73a9c97
Compare
standeren
force-pushed
the
12571-add-endpoint-to-delete-layout-set
branch
from
6eea09e to
753e181
Compare
Jondyr
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Add endpoint to delete layout set * Delete task id ref if layout set had a connected datatype and add tests * Add test for deleteMutation * Add new keyword to sets in layoutsets model * compare json content instead of objects * Delete App LayoutSets model * Do not remove selected layout set from local storage upon deletion --------- Co-authored-by: Mirko Sekulic <misha.sekulic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add endpoint that deletes a given layoutset in backend
Related Issue(s)
Verification