Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ProcessEditor): e.appendChild is not a function #12613

Merged
merged 2 commits into from
Apr 4, 2024
Merged

fix(ProcessEditor): e.appendChild is not a function #12613

merged 2 commits into from
Apr 4, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Apr 3, 2024 •
edited
Loading

Description

Fixed the following error:
image

Related Issue(s)

  • PR it self

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Apr 3, 2024
@framitdavid framitdavid changed the title Bug/append child error process fix(ProcessEditor): e.appendChild is not a function Apr 3, 2024
@framitdavid framitdavid added kind/bug Used when there is a defect / something is not working as it should. added-to-sprint labels Apr 3, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.67%. Comparing base (9aa95d5) to head (26e584c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12613      +/-   ##
==========================================
- Coverage   88.68%   88.67%   -0.01%     
==========================================
  Files        1288     1288              
  Lines       18515    18513       -2     
  Branches     2265     2265              
==========================================
- Hits        16420    16417       -3     
- Misses       1834     1835       +1     
  Partials      261      261

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost self-requested a review April 4, 2024 06:03
ghost
ghost approved these changes Apr 4, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 😄

@framitdavid framitdavid merged commit cb2f905 into main Apr 4, 2024
9 of 10 checks passed
@framitdavid framitdavid deleted the bug/appendChildErrorProcess branch April 4, 2024 06:15
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
@framitdavid @Jondyr
fix(ProcessEditor): e.appendChild is not a function (#12613)
f3b52c7 
* fix(ProcessEditor): typeNode.appendChild is not a function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
added-to-sprint area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@framitdavid