-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resourceadm: show alert if user does not have permission (is member of correct Gitea team) to publish resource or edit RRR access lists #12618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
One suggestion added.
frontend/resourceadm/components/ResourceAccessLists/ResourceAccessLists.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12618 +/- ##
==========================================
+ Coverage 88.70% 88.72% +0.02%
==========================================
Files 1289 1292 +3
Lines 18523 18560 +37
Branches 2269 2275 +6
==========================================
+ Hits 16430 16467 +37
Misses 1835 1835
Partials 258 258 ☔ View full report in Codecov by Sentry. |
…vironments to object, and remove org argument from getEnvLabel function
…f correct Gitea team) to publish resource or edit RRR access lists (#12618) * show error message if user does not have permission to read or edit resource accsslists * show error message if user does not have permission to publish resources * show environment name in publish success toast * change description text of resource name field * refactor: add new error component for access list errors. Refactor environments to object, and remove org argument from getEnvLabel function
Description
Related Issue(s)
Verification
Documentation