Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourceadm: add broker service resource type #12643

Merged
merged 12 commits into from
Apr 9, 2024
Merged

Conversation

mgunnerud
Copy link
Contributor

Description

  • Add new broker service resource type
  • Trim resource version before saving (don't allow version to be empty string)
  • Sort link services from Altinn 2 when displayed on import dropdown
  • Access list id and resource id fields are read-only
  • Show resource id in resource table
  • UU improvements for access list table

Related Issue(s)

  • None

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (418866d) to head (25455f0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12643   +/-   ##
=======================================
  Coverage   89.92%   89.93%           
=======================================
  Files        1291     1291           
  Lines       18399    18413   +14     
  Branches     2239     2240    +1     
=======================================
+ Hits        16546    16560   +14     
  Misses       1593     1593           
  Partials      260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots go good stuff here 😄
I added a few comments to consider

@mgunnerud mgunnerud merged commit d1e14c4 into main Apr 9, 2024
11 checks passed
@mgunnerud mgunnerud deleted the broker_service_resource branch April 9, 2024 13:15
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
* add broker service resource type

* do not allow empty space as resource version

* sort link services for import + show service owner code in import combobox

* show resource id and list id as readonly field

* show resource identifier in resource table

* add UU improvements to RRR table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant