-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resourceadm: add broker service resource type #12643
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
label
Apr 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12643 +/- ##
=======================================
Coverage 89.92% 89.93%
=======================================
Files 1291 1291
Lines 18399 18413 +14
Branches 2239 2240 +1
=======================================
+ Hits 16546 16560 +14
Misses 1593 1593
Partials 260 260 ☔ View full report in Codecov by Sentry. |
…ltinn-studio into broker_service_resource
ghost
reviewed
Apr 9, 2024
frontend/resourceadm/components/AccessListMembers/AccessListMembers.tsx
Outdated
Show resolved
Hide resolved
ghost
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots go good stuff here 😄
I added a few comments to consider
frontend/resourceadm/components/AccessListMembers/AccessListMembersTable.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/AccessListMembers/AccessListMembersTable.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/AccessListMembers/AccessListMembersTable.tsx
Outdated
Show resolved
Hide resolved
Jondyr
pushed a commit
that referenced
this pull request
Jun 10, 2024
* add broker service resource type * do not allow empty space as resource version * sort link services for import + show service owner code in import combobox * show resource id and list id as readonly field * show resource identifier in resource table * add UU improvements to RRR table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification
Documentation