Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Websockets): ensure to use the correct client names #12654

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Apr 10, 2024

Description

Extended the WSConnector class to get arguments about which event listeners to use.

Related Issue(s)

PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Apr 10, 2024
@framitdavid framitdavid added the kind/bug Used when there is a defect / something is not working as it should. label Apr 10, 2024
Copy link
Collaborator

@mirkoSekulic mirkoSekulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.94%. Comparing base (8d862b7) to head (0969f22).
Report is 2 commits behind head on main.

Files Patch % Lines
...tend/packages/shared/src/websockets/WSConnector.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12654      +/-   ##
==========================================
- Coverage   89.94%   89.94%   -0.01%     
==========================================
  Files        1291     1291              
  Lines       18414    18418       +4     
  Branches     2241     2241              
==========================================
+ Hits        16563    16566       +3     
- Misses       1592     1593       +1     
  Partials      259      259              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid changed the title fix(Websockets): ensure to use the correct event listeners name fix(Websockets): ensure to use the correct client names Apr 11, 2024
@framitdavid framitdavid merged commit 6d4d4a3 into main Apr 11, 2024
9 of 11 checks passed
@framitdavid framitdavid deleted the fix/useCorrectClientNames branch April 11, 2024 07:28
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
fix(Websockets): ensure to use the correct client names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants