Handle duplicated ids in layout #12665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/ui-editor
…color on accordion header and sectionHeader
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12665 +/- ##
==========================================
+ Coverage 90.13% 90.16% +0.02%
==========================================
Files 1301 1304 +3
Lines 18629 18673 +44
Branches 2265 2268 +3
==========================================
+ Hits 16792 16837 +45
+ Misses 1578 1577 -1
Partials 259 259 ☔ View full report in Codecov by Sentry. |
2 tasks
ghost
suggested changes
Apr 26, 2024
frontend/packages/ux-editor/src/components/Properties/PageConfigPanel/PageConfigPanel.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/DesignView.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/DesignView.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/FormLayout.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/FormLayoutWarning.module.css
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/FormLayoutWarning.tsx
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/PageAccordion/PageAccordion.module.css
Outdated
Show resolved
Hide resolved
github-actions
bot
added
area/data-modeling
Jondyr
pushed a commit
that referenced
this pull request
Jun 10, 2024
* enable layout with duplicated ids to return * display error if the layout contains duplicated ids * some adjustments of styling in accordion header * Display duplicated ids in the warning message * Add warning content in accordion when duplicated ids * add content to configWarning ++ * add endpoint for the specific layout in gitea * open link in new window * resize to small for list items + update text * move pageconfig warning content to a separated file * Make sure duplicated ids only display once * add text to text resources * change alert with sectionHeader, add new icon, keep the same warning color on accordion header and sectionHeader * remove comments * let isValid prop be optional * Remove some text * fix some tests + add objectutils test for flattenObjectValues * Add tests in pageConfigPanel * add tests to new formlayout utilities * add test to formlayout * fix text * feedback - change naming of text resources * replace @navikt/aksel-icons imports with @studio/icons in whole project * remove duplicated import of @studio-icons * feedbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When layout edits are made manually, resulting in components or containers with duplicate IDs, the layout doesn't display in Altinn Studio without any clear warning to the user except for a message in the console.
To improve this, implemented a feature that notifies users within Altinn Studio about the issue. Users will now receive a specific message identifying the duplicated IDs and directing them to resolve the issue in Gitea. This message includes step-by-step instructions and a link that opens the layout file in Gitea (in a new tab) for immediate correction.
Related Issue(s)
Verification
Documentation