Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @testing-library/react to v15 #12669

Merged
merged 15 commits into from
Apr 23, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 15, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@testing-library/react 14.3.1 -> 15.0.2 age adoption passing confidence
@testing-library/react ^14.0.0 -> ^15.0.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

testing-library/react-testing-library (@​testing-library/react)

v15.0.2

Compare Source

v15.0.1

Compare Source

v15.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 07:00 on Monday" in timezone Europe/Oslo, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/dependencies Used for issues or pull requests that are dependency updates labels Apr 15, 2024
@renovate renovate bot force-pushed the renovate/testing-library-react-15.x branch 5 times, most recently from d82ce05 to 578d8ca Compare April 16, 2024 07:21
@renovate renovate bot force-pushed the renovate/testing-library-react-15.x branch from 578d8ca to 9a996fc Compare April 16, 2024 09:44
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/dashboard Area: Related to the dashboard application area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/text-editor labels Apr 16, 2024
Copy link
Contributor Author

renovate bot commented Apr 16, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@lassopicasso lassopicasso self-assigned this Apr 16, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (9d21f3d) to head (359ac98).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12669   +/-   ##
=======================================
  Coverage   90.17%   90.18%           
=======================================
  Files        1299     1299           
  Lines       18573    18573           
  Branches     2261     2261           
=======================================
+ Hits        16749    16750    +1     
  Misses       1564     1564           
+ Partials      260      259    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassopicasso
Copy link
Contributor

This renovate update presented some challenges due to numerous failing tests, indirectly linked to the @testing-library/dom update as well.

To address the failures, I removed all instances of act throughout the project and when necessary I replaced them with wait or waitFor.
Additionally, I noticed stricter requirements for using getByRole after the update, which caused some failures that needed adjustment.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 👏 🥇

@lassopicasso lassopicasso merged commit eaca3da into main Apr 23, 2024
11 checks passed
@lassopicasso lassopicasso deleted the renovate/testing-library-react-15.x branch April 23, 2024 09:00
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
* chore(deps): update dependency @testing-library/react to v15

* removed lots of act()

* add some acts() ?

* remove unused imported act

* removed more unused acts

* more removal of unused acts :D

* fix tests adding waitFor instead of act

* replace the last acts

* fix last two tests

* some adjustments

* remove acts after merge with main

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: lassopicasso <lars.walderhaug@digdir.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/dashboard Area: Related to the dashboard application area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/dependencies Used for issues or pull requests that are dependency updates solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants