Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add layout set for data tasks #12676

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Apr 17, 2024

Description

Only add layout set when adding bpmn elements in the process editor that have taskType 'data'. This is due to the other taskTypes like confirmation and sign have default layouts in the apps in the app-developer does not add a layout set.
So adding and customizing the look of these steps should be optional and triggered by an active choice.

This PR does not include adding the possibility to trigger a creation of a related layoutset in the config panel for elements that are not data-tasks

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (e07f414) to head (c88677f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12676   +/-   ##
=======================================
  Coverage   90.11%   90.11%           
=======================================
  Files        1289     1289           
  Lines       18410    18410           
  Branches     2242     2242           
=======================================
  Hits        16590    16590           
  Misses       1561     1561           
  Partials      259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren marked this pull request as ready for review April 17, 2024 18:43
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@standeren standeren merged commit 378e7e3 into main Apr 18, 2024
10 checks passed
@standeren standeren deleted the only-add-layout-set-for-data-tasks branch April 18, 2024 09:23
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant