Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use command stack changes to trigger add/delete layout set #12681

Closed
wants to merge 1 commit into from

Conversation

standeren
Copy link
Contributor

Description

use event from bpmn modeler that is fired only on user interactions to trigger add/delete layout set instead of shape.add and shape.remove since these events are triggered on every new bpmn-mount.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Apr 18, 2024
@standeren standeren force-pushed the use-user-triggered-events-in-bpmn-hook branch from 1ec3e86 to f801b03 Compare April 18, 2024 11:29
@standeren standeren force-pushed the use-user-triggered-events-in-bpmn-hook branch from f801b03 to 79cee86 Compare April 18, 2024 11:31
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (378e7e3) to head (79cee86).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12681   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files        1296     1296           
  Lines       18553    18553           
  Branches     2259     2259           
=======================================
  Hits        16729    16729           
  Misses       1564     1564           
  Partials      260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@standeren standeren closed this Apr 19, 2024
@standeren
Copy link
Contributor Author

Closed this since the event did not act as assumed.
This PR introduces another fix for the core problem that introduced a smaller problem that this PR was suppose to fix

@standeren standeren deleted the use-user-triggered-events-in-bpmn-hook branch January 21, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants