-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resourceadm: improve validation #12683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
label
Apr 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12683 +/- ##
=======================================
Coverage 90.18% 90.19%
=======================================
Files 1299 1299
Lines 18573 18588 +15
Branches 2261 2261
=======================================
+ Hits 16750 16765 +15
Misses 1564 1564
Partials 259 259 ☔ View full report in Codecov by Sentry. |
ghost
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 😄
A few comments added
frontend/resourceadm/components/ResourcePageInputs/ResourceLanguageTextField.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/ResourceReferenceFields/ResourceReferenceFieldset.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/ResourceReferenceFields/ResourceReferenceFieldset.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/pages/DeployResourcePage/DeployResourcePage.tsx
Outdated
Show resolved
Hide resolved
Jondyr
pushed a commit
that referenced
this pull request
Jun 10, 2024
* show error if reference field does not contain MaskinportenScope reference * trim translation fields before save and validate * resource identifier must be at least 4 characters * UU improvement: add aria label to explain which field is edited * consistent button sizing * save resource reference select values on change instead of blur * agressive saving of resource version: save on change, not blur * add backend validation * improve accessible labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification
Documentation