Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace toLocalString with toISOSTring #12700

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Apr 23, 2024

Description

Make sure consistent time format. The test was failing locally on my computer

Related Issue(s)

  • itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lassopicasso lassopicasso added kind/bug Used when there is a defect / something is not working as it should. added-to-sprint labels Apr 23, 2024
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (eaca3da) to head (0933283).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12700   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files        1299     1299           
  Lines       18573    18573           
  Branches     2261     2261           
=======================================
  Hits        16750    16750           
  Misses       1564     1564           
  Partials      259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassopicasso lassopicasso merged commit ced14ac into main Apr 23, 2024
11 checks passed
@lassopicasso lassopicasso deleted the replace-toLocalString-with-toISOString branch April 23, 2024 09:27
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants