Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bpmnjs): Ensure that the user is fully informed about the consequences when deleting a task #12702

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Apr 23, 2024

Description

Before proceeding with deleting the task, we want to ensure that the user is fully informed about the consequences. Continuing will permanently remove the task including any associated layoutset from local changes.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Apr 23, 2024
@framitdavid framitdavid marked this pull request as ready for review April 23, 2024 12:08
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 90.13%. Comparing base (ced14ac) to head (bf811b4).

Files Patch % Lines
...r/src/bpmnProviders/SupportedContextPadProvider.js 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12702      +/-   ##
==========================================
- Coverage   90.18%   90.13%   -0.05%     
==========================================
  Files        1299     1299              
  Lines       18573    18583      +10     
  Branches     2261     2261              
==========================================
  Hits        16750    16750              
- Misses       1564     1574      +10     
  Partials      259      259              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid linked an issue Apr 23, 2024 that may be closed by this pull request
@framitdavid framitdavid changed the title feat(Bpmnjs): Override default action when deleting a task feat(Bpmnjs): Ensure that the user is fully informed about the consequences when deleting a task Apr 23, 2024
@framitdavid framitdavid enabled auto-merge (squash) April 23, 2024 12:36
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@framitdavid framitdavid merged commit 8f3eea8 into main Apr 24, 2024
5 of 7 checks passed
@framitdavid framitdavid deleted the feat/ensureTheUserWantsToDeleteTask branch April 24, 2024 10:49
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
…uences when deleting a task (#12702)

* feat(Bpmnjs): Override default action when deleting a task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show confirm dialogue when users deletes a task
2 participants