Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure autosave on layoutset switch is done for correct layoutset. #12703

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

nkylstad
Copy link
Member

Description

Seems like the issue was caused by the setup in FormItemContext.
There was an autosave set up for the "previous" layout/layoutset when changing layoutset. This was triggered when switching layoutsets, but the save was done for the newly selected layoutset, with context from the old layoutset.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Apr 23, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.17%. Comparing base (beed659) to head (9f1dc92).
Report is 10 commits behind head on main.

Files Patch % Lines
...kages/ux-editor/src/containers/FormItemContext.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12703   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files        1296     1296           
  Lines       18557    18557           
  Branches     2261     2261           
=======================================
  Hits        16733    16733           
  Misses       1564     1564           
  Partials      260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkylstad nkylstad merged commit 07edb5b into main Apr 24, 2024
10 of 11 checks passed
@nkylstad nkylstad deleted the bug(uiEditor)/12497-mixed-data-between-layout-sets branch April 24, 2024 08:30
@nkylstad nkylstad mentioned this pull request Apr 24, 2024
4 tasks
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
…12703)

* Ensure autosave on layoutset switch is done for correct layoutset.

* fixed layoutset ref to use correct value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants