-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component marked as not required
: remove properties that is updated to not set (undefined)
#12726
Conversation
not required
: remove properties that is updated to not set (undefined)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12726 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 1304 1304
Lines 18673 18677 +4
Branches 2268 2269 +1
=======================================
+ Hits 16837 16841 +4
Misses 1577 1577
Partials 259 259 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
Seems to work as expected for text/number input properties. F.ex. Boolean properties (f.ex. Another observation is that it is not possible to remove values that are set in a regular select. F.ex: Out of scope for this issue I would say, but we should maybe look into a pattern on how to remove a property from the layout in general 🤔 What do you think @Annikenkbrathen? Moving this to "Done", as the behaviour seems to work as expected! |
Yes, certainly! I don't have a deep understanding of this yet, but we can create an issue and look into it. I need to know when to remove a property, why, and what happens. Are we removing it from a single field, component, or page? Which properties are we talking about? |
… to not set (undefined) (#12726) * delete unused property that is not required * add unit test
Description
When a component is set to
not required
, any updates to its properties that result inundefined
are now removed. This ensures cleaner property configurations.Related to the work with #12559
Related Issue(s)
Verification
Documentation