Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove endEvent as a taskType and generalize iconSelection to also include sequenceFlow as a bpmnTypeEnum #12955

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

standeren
Copy link
Contributor

Description

Remove endEvent as a taskType and generalize iconSelection to also include sequenceFlow as a bpmnTypeEnum

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (d971752) to head (9e72c26).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12955   +/-   ##
=======================================
  Coverage   91.41%   91.42%           
=======================================
  Files        1397     1397           
  Lines       19740    19745    +5     
  Branches     2384     2385    +1     
=======================================
+ Hits        18046    18051    +5     
  Misses       1432     1432           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the remove-endEvent-as-taskType-and-add-icon-for-sequence branch from 5fab566 to 9e72c26 Compare June 14, 2024 06:52
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@standeren standeren merged commit b37b508 into main Jun 18, 2024
10 checks passed
@standeren standeren deleted the remove-endEvent-as-taskType-and-add-icon-for-sequence branch June 18, 2024 06:48
@standeren standeren removed their assignment Jun 18, 2024
@framitdavid
Copy link
Collaborator

Works as expected in dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants