Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12716 auto open parent components on drop #12962

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Jun 14, 2024

Description

To make this behaviour feel consistent these are the changes done:

  • Mark new nodes as selected when added to the tree view
  • Ensure all nodes are expanded/opened when a it or a child tree node is selected

This way, when either a new item is added through drag and drop or by button on the parent element (as described in #12038), the added element should be visible and expanded if applicable.

Related Issues

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Jondyr Jondyr linked an issue Jun 14, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jun 14, 2024
@Jondyr Jondyr added the area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (396c405) to head (e828356).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12962   +/-   ##
=======================================
  Coverage   91.46%   91.47%           
=======================================
  Files        1400     1401    +1     
  Lines       19821    19839   +18     
  Branches     2395     2397    +2     
=======================================
+ Hits        18130    18148   +18     
  Misses       1427     1427           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jondyr Jondyr force-pushed the 12716-auto-open-parent-components-on-drop branch from 006a306 to 14971fb Compare June 17, 2024 06:00
@Jondyr Jondyr marked this pull request as ready for review June 17, 2024 06:05
@Jondyr Jondyr linked an issue Jun 17, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Seems to work excellent in both ux-editor and data modeling! 😎
However, I have some comments that you can consider

@Jondyr Jondyr force-pushed the 12716-auto-open-parent-components-on-drop branch from 14971fb to e828356 Compare June 18, 2024 16:53
@Jondyr Jondyr merged commit 030107f into main Jun 18, 2024
11 checks passed
@Jondyr Jondyr deleted the 12716-auto-open-parent-components-on-drop branch June 18, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-open parent components on drop Automatically open tree view item when something is added
2 participants