-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12716 auto open parent components on drop #12962
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12962 +/- ##
=======================================
Coverage 91.46% 91.47%
=======================================
Files 1400 1401 +1
Lines 19821 19839 +18
Branches 2395 2397 +2
=======================================
+ Hits 18130 18148 +18
Misses 1427 1427
Partials 264 264 ☔ View full report in Codecov by Sentry. |
006a306
to
14971fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Seems to work excellent in both ux-editor and data modeling! 😎
However, I have some comments that you can consider
frontend/packages/schema-editor/src/components/SchemaTree/SchemaNode/SchemaNode.test.tsx
Outdated
Show resolved
Hide resolved
...tudio-components/src/components/StudioTreeView/hooks/useTreeViewItemOpenOnHierarchySelect.ts
Show resolved
Hide resolved
...udio-components/src/components/StudioTreeView/StudioTreeViewItem/StudioTreeViewItem.test.tsx
Show resolved
Hide resolved
...tudio-components/src/components/StudioTreeView/hooks/useTreeViewItemOpenOnHierarchySelect.ts
Show resolved
Hide resolved
Also opens node if selected, but allows it to be closed
14971fb
to
e828356
Compare
Description
To make this behaviour feel consistent these are the changes done:
This way, when either a new item is added through drag and drop or by button on the parent element (as described in #12038), the added element should be visible and expanded if applicable.
Related Issues
Verification
Documentation