Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Actions): re-implemented action with new UI #12982

Merged
merged 59 commits into from
Jun 27, 2024
Merged

feat(Actions): re-implemented action with new UI #12982

merged 59 commits into from
Jun 27, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Jun 18, 2024 •
edited
Loading

Description

This PR has refactored the user interface for how actions are handled in the process editor. Additionally, a new class called BpmnActionModeler has been added to create a simpler interface between the process editor and the bpmnjs package. (I had a meeting with the team to present the proposal before creating this pull request).

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
    (I did leave the ActionModeler out of tests, due to heavy mocking of bpmnjs.)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jun 18, 2024
@framitdavid framitdavid changed the title Feat/re implement actions feat(Actions): re-implement action with new UX Jun 21, 2024
@framitdavid framitdavid changed the title feat(Actions): re-implement action with new UX feat(Actions): re-implemented action with new UI Jun 21, 2024
@framitdavid framitdavid mentioned this pull request Jun 25, 2024
Merged
2 tasks
wrt95
wrt95 requested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments added 😄

@framitdavid
Copy link
Collaborator Author

Some comments added 😄

Thanks! I have taken your feedback into account and changed due to your suggestions. It's all yours! 😎

framitdavid and others added 3 commits June 27, 2024 11:03
@framitdavid @wrt95
PR feedback
f852b64 
Co-authored-by: William Thorenfeldt <48119543+wrt95@users.noreply.github.com>
@framitdavid @wrt95
PR feedback
d0576a8 
Co-authored-by: William Thorenfeldt <48119543+wrt95@users.noreply.github.com>
@framitdavid
Merge branch 'main' into feat/reImplementActions
31d3cb4
wrt95
wrt95 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! 🚀

@framitdavid framitdavid merged commit 0aa5b87 into main Jun 27, 2024
3 checks passed
@framitdavid framitdavid deleted the feat/reImplementActions branch June 27, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrt95 wrt95 wrt95 approved these changes

Assignees
No one assigned
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow-up the UX of pre/custom actions
2 participants
@framitdavid @wrt95