-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12634 implement validation across layouts when loading layout set with modal warning user of the issue #12988
Conversation
frontend/packages/ux-editor/src/components/Properties/PageConfigPanel/PageConfigPanel.test.tsx
Fixed
Show fixed
Hide fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12988 +/- ##
==========================================
+ Coverage 91.78% 91.80% +0.01%
==========================================
Files 1400 1402 +2
Lines 19827 19859 +32
Branches 2388 2390 +2
==========================================
+ Hits 18199 18231 +32
Misses 1371 1371
Partials 257 257 ☔ View full report in Codecov by Sentry. |
…ation-across-layouts-when-loading-layout-set-with-modal-warning-user-of-the-issue
…ation-across-layouts-when-loading-layout-set-with-modal-warning-user-of-the-issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This makes it easy for the user to find the errors and correct them. I like it a lot 😄
I have added some comments down below 😊
frontend/packages/ux-editor/src/components/Properties/PageConfigPanel/PageConfigPanel.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Properties/PageConfigPanel/PageConfigPanel.test.tsx
Outdated
Show resolved
Hide resolved
.../src/components/Properties/PageConfigPanel/PageConfigWarningModal/PageConfigWarningModal.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/PageAccordion/PageAccordion.tsx
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/PageAccordion/PageAccordion.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Properties/PageConfigPanel/PageConfigPanel.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Properties/PageConfigPanel/PageConfigPanel.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Properties/PageConfigPanel/PageConfigPanel.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/PageAccordion/PageAccordion.tsx
Outdated
Show resolved
Hide resolved
We worked on a similar design on the issue @lassopicasso worked on. I agree that we should mark the accordion that contains this conflict red. And if possible, mark the relevant components red aswell. In Lars's issue we decided to add a red background to the config that contains errors. So for now, maybe just add a red bakcround on the component (without spending time on making the icon and the red stroke) until we design the error pattern for Studio in general. And use the error validation from the designs system on the datamodel config And double-check that you have the same red color |
…ation-across-layouts-when-loading-layout-set-with-modal-warning-user-of-the-issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🚀
Description
Related Issue(s)
Verification
Documentation