-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create controller and service for options/code lists #13046
Conversation
…-studio into codelist-endpoints
backend/tests/Designer.Tests/Controllers/OptionsController/DeleteTests.cs
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! Impressive testing and documenting 😮💨
I have some questions concerning the need for 404 and duplicated error messages, as well as some nitpicking conserning naming 😅
Also I wonder if we should give the testfiles in the OptionsControllerTests more specific name like GetOptionsTests
and CreateOptionsTests
etc.
backend/tests/Designer.Tests/Controllers/OptionsController/GetTests.cs
Outdated
Show resolved
Hide resolved
backend/tests/Designer.Tests/Controllers/OptionsController/GetTests.cs
Outdated
Show resolved
Hide resolved
backend/tests/Designer.Tests/Controllers/OptionsController/GetTests.cs
Outdated
Show resolved
Hide resolved
backend/tests/Designer.Tests/Controllers/OptionsController/PutTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work!! 👏
Description
In this PR an
OptionsController
and anOptionsService
has been created.The
OptionsService
uses theAltinnAppGitRepository
to manipulate the options files.54 new endpoints have been added:POST a single option list to a repoConsiderations
GetOptions
,GetOptionLists
orGetCodeLists
. What do you think?Related Issue(s)
Verification
[AutoValidateAntiforgeryToken]