Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove signing data types from data types to sign #13048

Merged
merged 7 commits into from
Jul 1, 2024
Merged

Remove signing data types from data types to sign #13048

merged 7 commits into from
Jul 1, 2024

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Jun 28, 2024 •
edited
Loading

Description

Remove signing data types from data types to sign

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jun 28, 2024
@mlqn mlqn changed the title Remove signing and ref-data-as-pdf data types from data types to sign Remove signatureInformation and ref-data-as-pdf from data types to sign Jun 28, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (1071dbb) to head (2db16ce).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13048   +/-   ##
=======================================
  Coverage   91.69%   91.70%           
=======================================
  Files        1414     1414           
  Lines       19927    19935    +8     
  Branches     2396     2396           
=======================================
+ Hits        18273    18281    +8     
  Misses       1397     1397           
  Partials      257      257

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn changed the title Remove signatureInformation and ref-data-as-pdf from data types to sign Remove signatureInformation from data types to sign Jun 28, 2024
@mlqn mlqn changed the title Remove signatureInformation from data types to sign Remove signing data types from data types to sign Jun 28, 2024
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Jun 28, 2024
@mlqn mlqn changed the title Remove signing data types from data types to sign Remove signing and ref-data-as-pdf from data types to sign Jun 28, 2024
@mlqn mlqn marked this pull request as ready for review June 28, 2024 17:18
wrt95
wrt95 approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@mlqn mlqn changed the title Remove signing and ref-data-as-pdf from data types to sign Remove signing data types from data types to sign Jul 1, 2024
@mlqn mlqn merged commit 3d6a324 into main Jul 1, 2024
10 checks passed
@mlqn mlqn deleted the bug/fix-datatypestosign branch July 1, 2024 09:59
@mlqn mlqn mentioned this pull request Jul 1, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrt95 wrt95 wrt95 approved these changes

Assignees
No one assigned
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlqn @wrt95