Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning background to id-component in Properties. #13067

Conversation

JamalAlabdullah
Copy link
Contributor

Description

  • Added a logic to EditComponentIdRow to render the duplicated id-component with warning backgrund.
  • Updated tests in Properties and PropertiesHeader

Related issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jul 2, 2024
…ng-background-to-the-duplicated-id-in-the-config-panel
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (4490a3d) to head (1756eda).

Files Patch % Lines
...esHeader/EditComponentIdRow/EditComponentIdRow.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13067      +/-   ##
==========================================
- Coverage   91.89%   91.88%   -0.01%     
==========================================
  Files        1426     1426              
  Lines       19953    19957       +4     
  Branches     2388     2389       +1     
==========================================
+ Hits        18335    18338       +3     
  Misses       1360     1360              
- Partials      258      259       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 👍
I noticed a test that might not be verifying what it was intended to verify, so i added a comment and some suggestions.

…ng-background-to-the-duplicated-id-in-the-config-panel
@framitdavid framitdavid changed the title added warning backgrund to id-component in Properties. Added warning background to id-component in Properties. Jul 5, 2024
@JamalAlabdullah JamalAlabdullah merged commit 81e5f6a into main Jul 5, 2024
10 of 11 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 13043-add-a-red-warning-background-to-the-duplicated-id-in-the-config-panel branch July 5, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a red warning background to the duplicated id in the config panel
3 participants