-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added warning background to id-component in Properties. #13067
Added warning background to id-component in Properties. #13067
Conversation
…ng-background-to-the-duplicated-id-in-the-config-panel
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13067 +/- ##
==========================================
- Coverage 91.89% 91.88% -0.01%
==========================================
Files 1426 1426
Lines 19953 19957 +4
Branches 2388 2389 +1
==========================================
+ Hits 18335 18338 +3
Misses 1360 1360
- Partials 258 259 +1 ☔ View full report in Codecov by Sentry. |
…ng-background-to-the-duplicated-id-in-the-config-panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice 👍
I noticed a test that might not be verifying what it was intended to verify, so i added a comment and some suggestions.
...or/src/components/Properties/PropertiesHeader/EditComponentIdRow/EditComponentIdRow.test.tsx
Outdated
Show resolved
Hide resolved
...or/src/components/Properties/PropertiesHeader/EditComponentIdRow/EditComponentIdRow.test.tsx
Outdated
Show resolved
Hide resolved
...-editor/src/components/Properties/PropertiesHeader/EditComponentIdRow/EditComponentIdRow.tsx
Show resolved
Hide resolved
...roperties/PropertiesHeader/EditComponentIdRow/__snapshots__/EditComponentIdRow.test.tsx.snap
Outdated
Show resolved
Hide resolved
...-editor/src/components/Properties/PropertiesHeader/EditComponentIdRow/EditComponentIdRow.tsx
Outdated
Show resolved
Hide resolved
…ng-background-to-the-duplicated-id-in-the-config-panel
…ng-background-to-the-duplicated-id-in-the-config-panel
Description
EditComponentIdRow
to render the duplicated id-component with warning backgrund.Properties
andPropertiesHeader
Related issue(s)
Implement validation across layouts when loading layout-set, with modal warning user of the issue. #12634
Add a red warning background to the duplicated id in the config panel #13043
Verification
Documentation