-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10837 Review changed files in Altinn Studio #13095
10837 Review changed files in Altinn Studio #13095
Conversation
e4b2a4a
to
43dd61b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13095 +/- ##
=======================================
Coverage 91.89% 91.90%
=======================================
Files 1426 1427 +1
Lines 19986 20014 +28
Branches 2396 2396
=======================================
+ Hits 18367 18393 +26
Misses 1360 1360
- Partials 259 261 +2 ☔ View full report in Codecov by Sentry. |
43dd61b
to
7e0b610
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! The design looks great and the code is clean and neat. I just got a few comments. 🙂
...nControlButtons/components/ShareChangesPopover/CommitAndPushContent/CommitAndPushContent.tsx
Outdated
Show resolved
Hide resolved
...rolButtons/components/ShareChangesPopover/CommitAndPushContent/CommitAndPushContent.test.tsx
Outdated
Show resolved
Hide resolved
...nents/ShareChangesPopover/CommitAndPushContent/FileChangesInfoModal/FileChangesInfoModal.tsx
Show resolved
Hide resolved
...nts/GiteaHeader/VersionControlButtons/components/ShareChangesPopover/ShareChangesPopover.tsx
Show resolved
Hide resolved
7e0b610
to
26a6d0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Tested in dev - works as expected :) |
Description
1
in notification for shareChanges buttonMergeconflict
text in buttons for shareing and fetching changesSkjermopptak.2024-07-04.kl.14.16.02.mov
LocalChangesModal
Out of scope in this PR: implement support to review actual diff for each file. Should be done in a different PR
Related Issue(s)
Verification