Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12930 Moved hardcoded text from App.tsx to language files #13181

Merged
merged 12 commits into from
Jul 18, 2024
Merged

#12930 Moved hardcoded text from App.tsx to language files #13181

merged 12 commits into from
Jul 18, 2024

Conversation

Will-Marriott
Copy link
Contributor

Description

Removed the hardcoded text from App.tsx regarding errors, and reimplemented in language files. I've given a rough translation into English, but not 100% confident with it as I don't speak Norwegian.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/dashboard Area: Related to the dashboard application solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jul 17, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (94953ba) to head (338b80f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13181      +/-   ##
==========================================
- Coverage   92.76%   88.09%   -4.67%     
==========================================
  Files        1448        3    -1445     
  Lines       20306       42   -20264     
  Branches     2440        9    -2431     
==========================================
- Hits        18836       37   -18799     
+ Misses       1203        3    -1200     
+ Partials      267        2     -265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍

I noticed a small grammatical error in the original Norwegian definition, so I went ahead and made a minor correction.

Thank you for your contribution!

@ErlingHauan ErlingHauan added the external-contribution-❤️ Pull request from a developer outside the Altinn teams. label Jul 18, 2024
Added commas before "men"
Comma before "but"
@ErlingHauan ErlingHauan merged commit 724fc83 into Altinn:main Jul 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Area: Related to the dashboard application external-contribution-❤️ Pull request from a developer outside the Altinn teams. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move texts in getErrorMessage into language files
3 participants