-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12930 Moved hardcoded text from App.tsx to language files #13181
Conversation
12930 Moved hardcoded text from App.tsx to language files
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13181 +/- ##
==========================================
- Coverage 92.76% 88.09% -4.67%
==========================================
Files 1448 3 -1445
Lines 20306 42 -20264
Branches 2440 9 -2431
==========================================
- Hits 18836 37 -18799
+ Misses 1203 3 -1200
+ Partials 267 2 -265 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 👍
I noticed a small grammatical error in the original Norwegian definition, so I went ahead and made a minor correction.
Thank you for your contribution!
Added commas before "men"
Comma before "but"
Description
Removed the hardcoded text from App.tsx regarding errors, and reimplemented in language files. I've given a rough translation into English, but not 100% confident with it as I don't speak Norwegian.
Related Issue(s)
Verification
Documentation