Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redux #13193

Merged
Merged

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Jul 18, 2024

Description

  • Removed redux
  • Renamed renderWithMockStore and renderHookWithMockStore to renderWithProviders and renderHookWithProviders
  • Removed unused fetchDeployPermissions code
  • Removed deprecated fetchRemainingSession, keepAliveSession and SessionExpiredModal code
  • Removed unused /service-name endpoint

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@mlqn mlqn linked an issue Jul 18, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. kind/dependencies Used for issues or pull requests that are dependency updates labels Jul 18, 2024
@mlqn mlqn changed the title Remove redux Removed redux Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.61%. Comparing base (2eac343) to head (23fd6ae).
Report is 1 commits behind head on main.

Files Patch % Lines
frontend/app-development/test/testUtils.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13193      +/-   ##
==========================================
+ Coverage   92.95%   93.61%   +0.66%     
==========================================
  Files        1440     1423      -17     
  Lines       20118    19815     -303     
  Branches     2426     2402      -24     
==========================================
- Hits        18700    18550     -150     
+ Misses       1167     1015     -152     
+ Partials      251      250       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn marked this pull request as ready for review July 22, 2024 07:12
README.md Show resolved Hide resolved
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formidabelt!

@mlqn mlqn merged commit 5577d89 into main Jul 31, 2024
9 checks passed
@mlqn mlqn deleted the 10501-replace-redux-saga-with-react-query-in-app-development branch July 31, 2024 06:39
@mlqn mlqn added the skip-releasenotes Issues that do not make sense to list in our release notes label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/data-modeling Area: Related to data models - e.g. create, edit, use data models. kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
2 participants