Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drag and drop error in Playwright #13210

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Jul 22, 2024

Description

Updated the dragComponentIntoDroppableList method so that it doesn't matter whether the list is empty or not. I have also tried to clean up the code a bit, with a dragAndDropManually method on the BasePage class. This method should be used in favor of Playwright's dragTo method when we don't now exactly which element that will receive the drop event. In this case it may be either the list element or some unknown list item element, depending on whether the list is empty or not.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Jul 22, 2024
@TomasEng TomasEng force-pushed the fix-drag-and-drop-error-in-playwright branch 2 times, most recently from bcfacd8 to 349e8f9 Compare July 23, 2024 06:31
@TomasEng TomasEng force-pushed the fix-drag-and-drop-error-in-playwright branch from 349e8f9 to 1cd966f Compare July 23, 2024 06:43
@TomasEng TomasEng marked this pull request as ready for review July 23, 2024 06:54
@wrt95 wrt95 self-assigned this Jul 23, 2024
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👏

@wrt95 wrt95 assigned TomasEng and unassigned wrt95 Jul 23, 2024
@TomasEng TomasEng merged commit 7dfe88a into main Jul 23, 2024
7 checks passed
@TomasEng TomasEng deleted the fix-drag-and-drop-error-in-playwright branch July 23, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants