Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showed ellipsis in datamodelbinding accordion #13223

Merged

Conversation

JamalAlabdullah
Copy link
Contributor

Description

  • Showed ellipsis for datamodel binding accordion
  • Fixed overflow in dislayed datmodel in datamodel binding accordion

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Jul 23, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jul 23, 2024
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, looks like you solved the initial issue with ellipsis.
I discovered however a small styling issue that seems to stems from your last PR related to this fix.
This wrapper in DataModelBindings.ts removed the top/bottom padding of the bindings container.
Could you fix this as well in this PR? 🙏

image

Before:
image

After:
image

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (6a020ec) to head (42b3b4f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13223   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files        1441     1441           
  Lines       20159    20159           
  Branches     2417     2417           
=======================================
  Hits        18719    18719           
  Misses       1178     1178           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamalAlabdullah JamalAlabdullah merged commit a924ae2 into main Jul 24, 2024
9 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 13222-show-ellipsis-in-datamodellknytninger-accordion branch July 24, 2024 08:00
@JamalAlabdullah JamalAlabdullah changed the title shoed ellipsis in datamodelbinding accordion showed ellipsis in datamodelbinding accordion Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show ellipsis in datamodellknytninger accordion
2 participants