Add news to repo and change folder structure #13238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
solution/studio/designer
standeren
force-pushed
the
13101-move-newsjson-to-our-repo-and-create-pipeline-to-copypush-to-cdn
branch
from
c7a9ba0 to
4c7e2da
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13238 +/- ##
==========================================
- Coverage 93.71% 93.70% -0.01%
==========================================
Files 1431 1436 +5
Lines 19922 19919 -3
Branches 2420 2418 -2
==========================================
- Hits 18669 18665 -4
- Misses 1005 1006 +1
Partials 248 248 ☔ View full report in Codecov by Sentry. |
standeren
force-pushed
the
13101-move-newsjson-to-our-repo-and-create-pipeline-to-copypush-to-cdn
branch
from
4c7e2da to
c879f1d
Compare
standeren
force-pushed
the
13101-move-newsjson-to-our-repo-and-create-pipeline-to-copypush-to-cdn
branch
2 times, most recently
from
ef85fbd to
e660887
Compare
standeren
force-pushed
the
13101-move-newsjson-to-our-repo-and-create-pipeline-to-copypush-to-cdn
branch
from
e660887 to
553e691
Compare
|
Should we delete the news on CDN after this PR is deployed? 😊 |
framitdavid
approved these changes
Aug 13, 2024
frontend/app-development/features/overview/components/News/News.test.tsx
Outdated
Show resolved
Hide resolved
standeren
force-pushed
the
13101-move-newsjson-to-our-repo-and-create-pipeline-to-copypush-to-cdn
branch
3 times, most recently
from
a3fcf76 to
a865093
Compare
…with script to push new news to CDN
standeren
force-pushed
the
13101-move-newsjson-to-our-repo-and-create-pipeline-to-copypush-to-cdn
branch
from
a865093 to
fa4f602
Compare
standeren
changed the title
standeren
deleted the
13101-move-newsjson-to-our-repo-and-create-pipeline-to-copypush-to-cdn
branch
Jondyr
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Import news locally from repo instead of from cdn
standeren
added a commit
that referenced
this pull request
Aug 15, 2024
* Import news locally from repo instead of from cdn
standeren
added a commit
that referenced
this pull request
Aug 15, 2024
* Import news locally from repo instead of from cdn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
news.nb.jsonandnews.schema.jsonto new folder in news sectionindex.tsfiles to all the moved tsx. filesVerification