Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed icons #13332

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Fixed icons #13332

merged 4 commits into from
Aug 12, 2024

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Aug 9, 2024

Description

  • Fixed icons of the publishing and contact pages

Publishing page

BEFORE AFTER

icon-before

icon-after

Contact page

BEFORE AFTER

contact-before (1)

contact-after (1)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (6f23e3e) to head (ca316ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13332      +/-   ##
==========================================
- Coverage   93.69%   93.69%   -0.01%     
==========================================
  Files        1424     1424              
  Lines       19867    19861       -6     
  Branches     2417     2416       -1     
==========================================
- Hits        18614    18608       -6     
  Misses       1005     1005              
  Partials      248      248              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn marked this pull request as ready for review August 9, 2024 11:52
@github-actions github-actions bot added the area/studio-root Area: Issues related to studio-root application label Aug 10, 2024
@mlqn mlqn changed the title Fix icons of the publishing page Fix icons Aug 10, 2024
@mlqn mlqn changed the title Fix icons Fixed icons Aug 10, 2024
@lassopicasso lassopicasso self-assigned this Aug 12, 2024
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix and refactoring! 💪

@lassopicasso lassopicasso assigned mlqn and unassigned lassopicasso Aug 12, 2024
@mlqn mlqn merged commit c5009f7 into main Aug 12, 2024
8 checks passed
@mlqn mlqn deleted the bug/fix-publishing-icons branch August 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/studio-root Area: Issues related to studio-root application solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants