-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing "Publisert av" developer name in deploy page #13360
Fix missing "Publisert av" developer name in deploy page #13360
Conversation
…nform to similar code elsewhere
… to similar code elsewhere
…nform to similar code elsewhere
… to similar code elsewhere
829bd43
to
9d4d0c0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13360 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 1438 1438
Lines 19924 19924
Branches 2417 2417
=======================================
Hits 18670 18670
Misses 1006 1006
Partials 248 248 ☔ View full report in Codecov by Sentry. |
…sion' of https://github.com/Altinn/altinn-studio into 13335-publisert-av-is-missing-when-publishing-a-new-version
…sion' of https://github.com/Altinn/altinn-studio into 13335-publisert-av-is-missing-when-publishing-a-new-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job cleaning this up! 🙌
I have one comment/suggestion for you to consider, not actually something changed by your PR, but might be nice to do - up to you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in dev :)
Description
We no longer use the claim
AltinnCoreClaimTypes
, but it still existed in some parts of our code.This caused the developer name under the heading "Publisert av" to be missing from the deployment page.
By retrieving the developer's username from
AuthenticationHelper
instead, this has been fixed.AltinnCoreClaimTypes
has also been removed from all tests.Related Issue(s)
Publisert av
is missing when publishing a new version #13335Verification