Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing "Publisert av" developer name in deploy page #13360

Merged

Conversation

ErlingHauan
Copy link
Contributor

@ErlingHauan ErlingHauan commented Aug 14, 2024

Description

We no longer use the claim AltinnCoreClaimTypes, but it still existed in some parts of our code.
This caused the developer name under the heading "Publisert av" to be missing from the deployment page.
By retrieving the developer's username from AuthenticationHelper instead, this has been fixed.

AltinnCoreClaimTypes has also been removed from all tests.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Sorry, something went wrong.

@ErlingHauan ErlingHauan linked an issue Aug 14, 2024 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Aug 14, 2024
@ErlingHauan ErlingHauan changed the title get CreatedBy from AuthenticationHelper instead of Claims and add mor… Fix retrieval of developer username for "Publisert av" in deployment page Aug 14, 2024
@ErlingHauan ErlingHauan force-pushed the 13335-publisert-av-is-missing-when-publishing-a-new-version branch from 829bd43 to 9d4d0c0 Compare August 14, 2024 11:59
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (eece61b) to head (f278868).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13360   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files        1438     1438           
  Lines       19924    19924           
  Branches     2417     2417           
=======================================
  Hits        18670    18670           
  Misses       1006     1006           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErlingHauan ErlingHauan changed the title Fix retrieval of developer username for "Publisert av" in deployment page Remove AltinnCoreClaimTypes from code base Aug 14, 2024
…sion' of https://github.com/Altinn/altinn-studio into 13335-publisert-av-is-missing-when-publishing-a-new-version
@ErlingHauan ErlingHauan marked this pull request as ready for review August 16, 2024 10:45
…sion' of https://github.com/Altinn/altinn-studio into 13335-publisert-av-is-missing-when-publishing-a-new-version
@ErlingHauan ErlingHauan changed the title Remove AltinnCoreClaimTypes from code base Fix missing "Publisert av" developer name in deploy page Aug 16, 2024
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job cleaning this up! 🙌
I have one comment/suggestion for you to consider, not actually something changed by your PR, but might be nice to do - up to you!

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev :)

@lassopicasso lassopicasso merged commit f0afd1a into main Aug 22, 2024
15 checks passed
@lassopicasso lassopicasso deleted the 13335-publisert-av-is-missing-when-publishing-a-new-version branch August 22, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publisert av is missing when publishing a new version
3 participants