Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(LogicalExpressionEditor): refactor to use UseUniqueKeys #13361

Merged

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Aug 14, 2024

Description

We have implemented a custom hook called useUniqueKeys to manage lists that lack unique identifiers for individual items. This hook dynamically generates unique keys for each item, ensuring that our list elements can be efficiently tracked and manipulated in React components. I refactored the LogicalExpresisonEditor to use the useUniqueKeys hook.

Related Issue(s)

  • PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (9c04e2a) to head (0300342).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13361      +/-   ##
==========================================
- Coverage   93.71%   93.70%   -0.01%     
==========================================
  Files        1431     1431              
  Lines       19922    19916       -6     
  Branches     2420     2419       -1     
==========================================
- Hits        18669    18663       -6     
  Misses       1005     1005              
  Partials      248      248              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid marked this pull request as ready for review August 14, 2024 07:36
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Herlig!

@framitdavid framitdavid merged commit f507617 into main Aug 14, 2024
8 checks passed
@framitdavid framitdavid deleted the chore/refactorLocicalExpressionEditorUseUniqueKeys branch August 14, 2024 10:03
Jondyr pushed a commit that referenced this pull request Aug 14, 2024
chore(LogicalExpressionEditor): refactor to use UseUniqueKeys
standeren pushed a commit that referenced this pull request Aug 15, 2024
chore(LogicalExpressionEditor): refactor to use UseUniqueKeys
standeren pushed a commit that referenced this pull request Aug 15, 2024
chore(LogicalExpressionEditor): refactor to use UseUniqueKeys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants