Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use grid display for app container #13363

Merged
merged 2 commits into from
Aug 15, 2024
Merged

use grid display for app container #13363

merged 2 commits into from
Aug 15, 2024

Conversation

standeren
Copy link
Contributor

Description

Removes empty space under overview page
Skjermbilde 2024-08-14 kl  12 48 36

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (ff116f2) to head (6de4ab7).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13363   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files        1436     1436           
  Lines       19919    19919           
  Branches     2418     2418           
=======================================
  Hits        18665    18665           
  Misses       1006     1006           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn self-assigned this Aug 14, 2024
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🤩 I just noticed one thing, the page is no longer responsive since we started using grid in the Overview.module.css and App.module.css; all blocks stay in their original position:

BEFORE (with flex) AFTER (with grid)
overview-before.webm
overview-after.webm

@standeren
Copy link
Contributor Author

Nice! 🤩 I just noticed one thing, the page is no longer responsive since we started using grid in the Overview.module.css and App.module.css; all blocks stay in their original position:

BEFORE (with flex) AFTER (with grid)
overview-before.webm
overview-after.webm

Ah nice, I see! Fixing it now. But I cannot avoid getting a scrollbar at the bottom, due to the header not allowing to be that narrow 🫣

Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💯

@standeren standeren merged commit 7ebcc01 into main Aug 15, 2024
9 checks passed
@standeren standeren deleted the fix-app-container-css branch August 15, 2024 08:53
standeren added a commit that referenced this pull request Aug 15, 2024
* use grid display for app container

* Fix PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants