-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use grid display for app container #13363
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13363 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 1436 1436
Lines 19919 19919
Branches 2418 2418
=======================================
Hits 18665 18665
Misses 1006 1006
Partials 248 248 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🤩 I just noticed one thing, the page is no longer responsive since we started using grid
in the Overview.module.css
and App.module.css
; all blocks stay in their original position:
BEFORE (with flex) | AFTER (with grid) |
---|---|
overview-before.webm |
overview-after.webm |
Ah nice, I see! Fixing it now. But I cannot avoid getting a scrollbar at the bottom, due to the header not allowing to be that narrow 🫣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 💯
* use grid display for app container * Fix PR comments
Description
Removes empty space under overview page