-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-editor): export form definition #13390
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13390 +/- ##
==========================================
- Coverage 93.75% 93.68% -0.07%
==========================================
Files 1448 1455 +7
Lines 20037 20168 +131
Branches 2430 2442 +12
==========================================
+ Hits 18785 18894 +109
- Misses 1004 1023 +19
- Partials 248 251 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the PR and it's great to see that you've managed to create a format for export—well done! 👏 🚀 I've added some comments and suggestions, but I didn't address every detail. My understanding is that "Forsvaret" will review this feature after merge and make any necessary changes and build this further?
frontend/packages/ux-editor/src/components/Elements/ExportForm.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/Elements/ExportForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! By adding the refactoring you have done, the codebase become even more modular. 👏
frontend/libs/studio-components/src/components/StudioBlobDownloader/StudioBlobDownloader.mdx
Outdated
Show resolved
Hide resolved
...end/libs/studio-components/src/components/StudioBlobDownloader/StudioBlobDownloader.test.tsx
Outdated
Show resolved
Hide resolved
...end/libs/studio-components/src/components/StudioBlobDownloader/StudioBlobDownloader.test.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioBlobDownloader/StudioBlobDownloader.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-pure-functions/src/BlobDownloader/BlobDownloader.test.ts
Outdated
Show resolved
Hide resolved
For some reason, a test in Switching to UPDATE: Switching to a relative import (since we're in the same lib) over a package import also did the trick, but I don't really understand why my code caused this 🤔 |
@nkylstad Seems like this PR still need some improved code coverage and a more semantic PR title to be mergable. Are you or anybody from your team able to look into this so we could get this one merged? |
@Aalsaunet We're ok with the code coverage, and PR title is fixed! @framitdavid has tested the change on his machine, and the feature is behind a feature flag. Merging now, and this commit will be deployed tomorrow. To turn on the feature (with feature flag), add the url param |
Great! Thank you so much for fixing it @nkylstad ! I'll make sure to test it out and starting looking into XML exports right away 😊 |
Description
Ref. discussion in daily, this is a feature that has been requested externally, and we are making it available behind a feature flag for now.
Skjermopptak.2024-08-19.kl.12.23.53.mov
Verification
Documentation