Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/k8s wrapper deploy #13392

Merged
merged 21 commits into from
Aug 20, 2024
Merged

feature/k8s wrapper deploy #13392

merged 21 commits into from
Aug 20, 2024

Conversation

mirkoSekulic
Copy link
Collaborator

@mirkoSekulic mirkoSekulic commented Aug 19, 2024 •
edited
Loading

Description

Add deploy workflow for kubernetes wrapper.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the skip-releasenotes Issues that do not make sense to list in our release notes label Aug 19, 2024
@mirkoSekulic mirkoSekulic marked this pull request as draft August 19, 2024 17:17
@mirkoSekulic mirkoSekulic linked an issue Aug 19, 2024 that may be closed by this pull request
Migrate KubernetesWrapper to pull based deploy #13276
Closed
@mirkoSekulic mirkoSekulic marked this pull request as ready for review August 19, 2024 19:41
@mirkoSekulic @framitdavid
Update charts/kuberneteswrapper/Chart.yaml
3a7278f 
Co-authored-by: David Ovrelid <46874830+framitdavid@users.noreply.github.com>
framitdavid
framitdavid approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved Code Review!

ErlingHauan
ErlingHauan approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to fulfill two approvals.

@mirkoSekulic mirkoSekulic merged commit 29196be into main Aug 20, 2024
1 check passed
@mirkoSekulic mirkoSekulic deleted the feature/k8s-wrapper-deploy branch August 20, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErlingHauan ErlingHauan ErlingHauan approved these changes

@framitdavid framitdavid framitdavid approved these changes

Assignees
No one assigned
Labels
skip-releasenotes Issues that do not make sense to list in our release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate KubernetesWrapper to pull based deploy
3 participants
@mirkoSekulic @framitdavid @ErlingHauan