-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated lines in Husky pre-commit script #13396
Remove deprecated lines in Husky pre-commit script #13396
Conversation
…ttps://github.com/Altinn/altinn-studio into 13395-deprecated-lines-in-husky-pre-commit-script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also change the setup for husky in package.json?
- `"setup": "husky install && node development/setup.js && yarn run git:ignore-revs",`
+ `"setup": "husky && node development/setup.js && yarn run git:ignore-revs",`
From the migration guide:
package.json
{
"scripts": {
- "prepare": "husky install"
+ "prepare": "husky"
}
}
Good catch! Fixed now 😊 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13396 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 1438 1438
Lines 19929 19929
Branches 2417 2417
=======================================
Hits 18679 18679
Misses 1002 1002
Partials 248 248 ☔ View full report in Codecov by Sentry. |
Description
When running
git commit
we got the following warning:In this PR these lines were removed, as recommended under the section "How to migrate" at the bottom of this page: https://github.com/typicode/husky/releases/tag/v9.0.1
Related Issue(s)
Verification