Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update nb.json #13492

Merged
merged 1 commit into from
Sep 6, 2024
Merged

refactor: Update nb.json #13492

merged 1 commit into from
Sep 6, 2024

Conversation

Ildest
Copy link
Contributor

@Ildest Ildest commented Sep 5, 2024

Description

Changed "Miniprogrammer" back to "Widgets", as advised by @nkylstad in a comment in our terminology spreadsheet. 1 occurrence found.

Related Issue(s)

  • PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

Changed "Miniprogrammer" back to "Widgets", as advised by @nkylstad in a comment in our terminology spreadsheet. 1 occurrence found.
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 5, 2024
@Ildest Ildest requested a review from framitdavid September 5, 2024 12:05
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (1bb09ba) to head (986619c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13492   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files        1455     1455           
  Lines       20168    20168           
  Branches     2442     2442           
=======================================
  Hits        18894    18894           
  Misses       1023     1023           
  Partials      251      251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great job! The only missing part is to rename PR title from refactoring to refactor. 😊

@framitdavid framitdavid changed the title refactoring: Update nb.json refactor: Update nb.json Sep 5, 2024
@mlqn mlqn merged commit 6ac454a into main Sep 6, 2024
9 of 14 checks passed
@mlqn mlqn deleted the Ildest-patch-2 branch September 6, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants