Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workspace): Update main README.md #13514

Merged
merged 6 commits into from
Sep 16, 2024
Merged

chore(workspace): Update main README.md #13514

merged 6 commits into from
Sep 16, 2024

Conversation

Konrad-Simso
Copy link
Contributor

Description

Updated README.md with the following changes:

  • Added anchors for all external links.
  • Updated prerequisites to match the current solution.
  • Updated languages for code blocks to match their content.
  • Added a new section called "Playwright tests".

Solves Issue(s)

New issue needs to be solved later:

- Extracted links as anchors.
- Changed Node.js note to reflect correct version.
- Edited Docker Desktop notes
- Removed World Wide Web Publishing Service as it's no longer in use.
- Added languages to code blocks.
- Added Playwright section.
@Konrad-Simso Konrad-Simso linked an issue Sep 10, 2024 that may be closed by this pull request
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, @Konrad-Simso ! This is great work! I have a few comments related to cypress.

- Edited Playwright section, link and wording.
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re good to go and can move this to testing after this typo below is fixed. 👍

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testet OK.

@framitdavid framitdavid merged commit 9fefd93 into main Sep 16, 2024
2 checks passed
@framitdavid framitdavid deleted the docs/update-readme branch September 16, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md is outdated
4 participants