fix: ResizableLayoutContainer no longer overflows #13533
Merged
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed maxWidth for StudioResizableLayoutElement to use Rem instead of Pixels. - Added maxWidth of `100VW` to StudioResizableLayoutContainer - Added fullWidth to both Elements.tsx and Preview.tsx, so that when the buttons are collapsed, they take up all the space they can use.
It comes down to using Rems vs Pixels. The bug was making the Preview section resize randomly, now that's fixed.
github-actions
bot
added
area/ui-editor
...ents/StudioResizableLayout/StudioResizableLayoutContainer/StudioResizableLayoutContainer.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13533 +/- ##
=======================================
Coverage 95.16% 95.17%
=======================================
Files 1462 1462
Lines 20149 20149
Branches 2439 2439
=======================================
+ Hits 19175 19176 +1
Misses 868 868
+ Partials 106 105 -1 ☔ View full report in Codecov by Sentry. |
|
There are some spacing issues that need attention. I thought Prettier would handle that, but it seems not. Could you take care of it? Once that's done, it's good to go! 😄 https://github.com/Altinn/altinn-studio/actions/runs/10831581581/job/30053889792?pr=13533 |
The issue arrised from commits made yesterday because of having to bypassing husky to make commits. The local issue has been resolved and won't happen in the future.
|
Testet OK. |
TomasEng
approved these changes
Sep 16, 2024
Konrad-Simso
deleted the
fix/resizableLayoutContainer-overflowing-by-default
branch
standeren
pushed a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ResizableLayoutContainer, ensuring it no longer exceeds the screen size.fullWidthproperty for bothStudioButtonsused whenPreviewandElementsare collapsed. This adjustment allows the buttons to occupy the full width of their parent container, which is constrained bycollapseSize. Previously, there were gaps between the buttons and their containers.Related Issue(s)
Verification