Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implementing StudioPageHeader component #13559

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Sep 17, 2024

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 requested a review from framitdavid September 17, 2024 09:01
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 17, 2024
@wrt95 wrt95 changed the title Feat: Implementing StudioPageHeader component feat: Implementing StudioPageHeader component Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.21%. Comparing base (f2f7f9c) to head (e97df18).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...c/components/StudioPageHeader/StudioPageHeader.tsx 83.33% 1 Missing ⚠️
...ader/StudioPageHeaderLeft/StudioPageHeaderLeft.tsx 80.00% 1 Missing ⚠️
...omponents/src/components/StudioPageHeader/index.ts 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13559   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files        1475     1494   +19     
  Lines       20335    20425   +90     
  Branches     2459     2469   +10     
=======================================
+ Hits        19361    19448   +87     
- Misses        869      872    +3     
  Partials      105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I had some comments be considered. Nice and small PR.

@wrt95 wrt95 requested a review from framitdavid September 18, 2024 08:34
@Jondyr Jondyr self-requested a review September 18, 2024 14:27
@wrt95 wrt95 merged commit 1fa42ed into main Sep 18, 2024
9 checks passed
@wrt95 wrt95 deleted the Feat--StudioPageHeader branch September 18, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants