-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SubForm component #13564
feat: add SubForm component #13564
Conversation
95d3084
to
5d51cce
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13564 +/- ##
==========================================
- Coverage 95.18% 95.17% -0.01%
==========================================
Files 1470 1470
Lines 20235 20237 +2
Branches 2448 2449 +1
==========================================
+ Hits 19260 19261 +1
Misses 870 870
- Partials 105 106 +1 ☔ View full report in Codecov by Sentry. |
starting review |
18e5995
to
e58530f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 💪 I like how you've used the .filter(Boolean)
technique to conditionally display the SubForm.
I have one comment below, and I’m also curious about how the new text keys, e.g. ux_editor.component_properties.summaryDelimiter
, are being used. Could you provide some context on that?
It is a new property added for the subFrom-component. So we are able to render it with our autogenerated config since it is We definetly should add translations for these, but I think there is a separate issue for that! |
Thx for the explanation, @standeren ! I'm not that used to the autogenerated config 😄 |
e58530f
to
fca2c45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solved with the updated test, @standeren 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK with and without feature flag 😊
Description
Add SubFrom component but hide it in component-list behind featureFlag.
If an app should have a subform component i the layout added manually the config will show, but, since Team Apps have not released the component yet any potential apps that have this component are using it for test-purposes.
When Team Apps release the component we should include the featureflag for the new config that we create.
@Annikenkbrathen Currently used the
ClipBoard
icon from Aksel Icons. But we can adapt it later.Related Issue(s)
Verification