Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implementing StudioAvatar #13572

Merged
merged 8 commits into from
Sep 19, 2024
Merged

feat: Implementing StudioAvatar #13572

merged 8 commits into from
Sep 19, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Sep 18, 2024

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 requested a review from framitdavid September 18, 2024 14:07
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (1fa42ed) to head (b429d34).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13572   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files        1494     1495    +1     
  Lines       20425    20430    +5     
  Branches     2469     2470    +1     
=======================================
+ Hits        19448    19453    +5     
  Misses        872      872           
  Partials      105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid
Copy link
Collaborator

Review started

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and small PR! Love that! 👏 🤩

@framitdavid framitdavid assigned wrt95 and unassigned framitdavid Sep 19, 2024
@wrt95 wrt95 requested a review from framitdavid September 19, 2024 09:43
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fin komponent. Godkjenner siden David allerede har gitt sin velsignelse, men se gjerne på kommentarene jeg la til.

@TomasEng TomasEng enabled auto-merge (squash) September 19, 2024 11:20
@TomasEng TomasEng merged commit d8b9ac2 into main Sep 19, 2024
5 of 6 checks passed
@TomasEng TomasEng deleted the feat-StudioAvatar branch September 19, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants