Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support summary 2 configuration for components, pages and selected layout set #13573

Merged
merged 46 commits into from
Sep 25, 2024
Merged

feat: support summary 2 configuration for components, pages and selected layout set #13573

merged 46 commits into from
Sep 25, 2024

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Sep 18, 2024 •
edited
Loading

Description

These changes are behind the featureflag summary2 ( #13571 )

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Sep 18, 2024
@Jondyr Jondyr linked an issue Sep 18, 2024 that may be closed by this pull request
Support Summary-2 configuration for component, page and layout-set. #13519
Closed
4 tasks
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (c0c8c24) to head (edaa3ed).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13573      +/-   ##
==========================================
+ Coverage   95.22%   95.23%   +0.01%     
==========================================
  Files        1499     1502       +3     
  Lines       20499    20554      +55     
  Branches     2485     2491       +6     
==========================================
+ Hits        19520    19575      +55     
  Misses        869      869              
  Partials      110      110

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jondyr Jondyr marked this pull request as ready for review September 19, 2024 14:05
wrt95
wrt95 reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of great code here @Jondyr! 👏
I've added some comments for consideration 😄

@Jondyr Jondyr requested a review from wrt95 September 24, 2024 13:10
Jondyr and others added 2 commits September 25, 2024 08:43
@Jondyr @wrt95
Update frontend/packages/ux-editor/src/components/config/componentSpe…
75196cb 
…cificContent/Summary2/Summary2Component.tsx

Co-authored-by: William Thorenfeldt <48119543+wrt95@users.noreply.github.com>
@Jondyr
Expand on excludedComponents list comment
8d0f96b
wrt95
wrt95 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👏

@Jondyr Jondyr removed their assignment Sep 25, 2024
JamalAlabdullah
JamalAlabdullah approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok👍

@JamalAlabdullah JamalAlabdullah merged commit cbd6c29 into main Sep 25, 2024
17 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 13519-support-summary-2-configuration-for-component-page-and-layout-set branch September 25, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrt95 wrt95 wrt95 approved these changes

@JamalAlabdullah JamalAlabdullah JamalAlabdullah approved these changes

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Summary-2 configuration for component, page and layout-set.
4 participants
@Jondyr @wrt95 @JamalAlabdullah @ErlingHauan