Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement StudioProfileMenu #13581

Merged
merged 12 commits into from
Sep 24, 2024
Merged

feat: Implement StudioProfileMenu #13581

merged 12 commits into from
Sep 24, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Sep 19, 2024

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 changed the title Implement StudioProfileMenu feat: Implement StudioProfileMenu Sep 19, 2024
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.22%. Comparing base (3c09043) to head (0a2ab8f).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...components/StudioProfileMenu/StudioProfileMenu.tsx 88.46% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13581      +/-   ##
==========================================
+ Coverage   95.20%   95.22%   +0.01%     
==========================================
  Files        1498     1499       +1     
  Lines       20470    20499      +29     
  Branches     2476     2485       +9     
==========================================
+ Hits        19489    19520      +31     
+ Misses        873      869       -4     
- Partials      108      110       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrt95 wrt95 added the frontend label Sep 24, 2024
@ErlingHauan ErlingHauan self-assigned this Sep 24, 2024
@ErlingHauan
Copy link
Contributor

Starting review

Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and flexible component! And the code is extremely clean 💯
I only have a few comments.

@ErlingHauan ErlingHauan assigned wrt95 and unassigned ErlingHauan Sep 24, 2024
@wrt95 wrt95 removed their assignment Sep 24, 2024
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@wrt95 wrt95 merged commit fe4e468 into main Sep 24, 2024
8 of 9 checks passed
@wrt95 wrt95 deleted the feat-StudioProfileMenu branch September 24, 2024 13:15
Jondyr pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants