-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement StudioProfileMenu #13581
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13581 +/- ##
==========================================
+ Coverage 95.20% 95.22% +0.01%
==========================================
Files 1498 1499 +1
Lines 20470 20499 +29
Branches 2476 2485 +9
==========================================
+ Hits 19489 19520 +31
+ Misses 873 869 -4
- Partials 108 110 +2 ☔ View full report in Codecov by Sentry. |
frontend/libs/studio-components/src/components/StudioProfileMenu/StudioProfileMenu.tsx
Show resolved
Hide resolved
Starting review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and flexible component! And the code is extremely clean 💯
I only have a few comments.
frontend/libs/studio-components/src/components/StudioProfileMenu/StudioProfileMenu.tsx
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioProfileMenu/StudioProfileMenu.tsx
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioProfileMenu/StudioProfileMenu.test.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-components/src/components/StudioProfileMenu/StudioProfileMenu.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
Description
Related Issue(s)
Verification