-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add defaultValue from schema to EditBooleanValue component #13584
fix: Add defaultValue from schema to EditBooleanValue component #13584
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13584 +/- ##
==========================================
+ Coverage 95.21% 95.23% +0.01%
==========================================
Files 1495 1495
Lines 20435 20434 -1
Branches 2471 2470 -1
==========================================
+ Hits 19458 19461 +3
+ Misses 872 868 -4
Partials 105 105 ☔ View full report in Codecov by Sentry. |
d264a7f
to
4eb06a4
Compare
review started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🪨 But is this a bug that we should fix for v3 apps as well? 🤔
Good point! I'll have a look! 💪 |
c959810
to
e0c4e5f
Compare
e0c4e5f
to
331a3a5
Compare
frontend/packages/ux-editor-v3/src/components/config/editModal/EditBooleanValue.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditBooleanValue.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test OK, works as expected.
Description
Ensure default boolean values that are
true
from boolean properties in component schemas is reflected astrue
in config panel by checking the switch using the default value if there is no value from the component.Related Issue(s)
Verification