Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactoring logout logic #13595

Merged
merged 4 commits into from
Sep 23, 2024
Merged

feat: Refactoring logout logic #13595

merged 4 commits into from
Sep 23, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Sep 23, 2024

Description

  • Refactor logic for handling logout

Related Issue(s)

  • PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 23, 2024
@wrt95 wrt95 changed the title Refactoring logout logic feat: Refactoring logout logic Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (0135373) to head (638b758).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13595   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files        1497     1498    +1     
  Lines       20458    20466    +8     
  Branches     2476     2476           
=======================================
+ Hits        19477    19485    +8     
  Misses        873      873           
  Partials      108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@framitdavid framitdavid merged commit 838914f into main Sep 23, 2024
9 checks passed
@framitdavid framitdavid deleted the Refactor-logout-logic branch September 23, 2024 20:44
@nkylstad
Copy link
Member

Merged this PR, as we needed to trigger a full production deploy. This PR seemed pretty safe, as it was approved, and adds a new hook that is not used yet 😊

@wrt95 wrt95 added the frontend label Sep 24, 2024
standeren pushed a commit that referenced this pull request Sep 24, 2024
Jondyr pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants