-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flaky playwright tests #13600
fix: flaky playwright tests #13600
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13600 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 1497 1497
Lines 20455 20455
Branches 2473 2473
=======================================
Hits 19476 19476
Misses 872 872
Partials 107 107 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great spotted! 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving without test, as it's difficult to test
Description
Rename the datamodel being created on lines 133 -> 140 from "testDataModel" to "testDataModel2".
The rename is needed because another datamodel is created earlier in the same file with the name "testDataModel".
Related Issue(s)
Verification