Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky playwright tests #13600

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: flaky playwright tests #13600

merged 2 commits into from
Sep 25, 2024

Conversation

Konrad-Simso
Copy link
Contributor

@Konrad-Simso Konrad-Simso commented Sep 23, 2024

Description

Rename the datamodel being created on lines 133 -> 140 from "testDataModel" to "testDataModel2".
The rename is needed because another datamodel is created earlier in the same file with the name "testDataModel".

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Sep 23, 2024
@Konrad-Simso Konrad-Simso changed the title Test commit, rename 2nd create dataModel name to something different … chore: playwright tests rename a dataModel Sep 23, 2024
@Konrad-Simso Konrad-Simso changed the title chore: playwright tests rename a dataModel fix: flaky playwright tests Sep 23, 2024
@Konrad-Simso Konrad-Simso marked this pull request as ready for review September 23, 2024 11:52
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (ed8886d) to head (7098dc8).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13600   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files        1497     1497           
  Lines       20455    20455           
  Branches     2473     2473           
=======================================
  Hits        19476    19476           
  Misses        872      872           
  Partials      107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spotted! 🥳

Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving without test, as it's difficult to test

@ErlingHauan ErlingHauan merged commit 9bdf6e2 into main Sep 25, 2024
10 checks passed
@ErlingHauan ErlingHauan deleted the fix/playwright_ui_editor_tests branch September 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Playwright test passing with a flaky result. Need to look into when/why it is failing.
3 participants