Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update Typescript #13602

Merged
merged 9 commits into from
Sep 25, 2024
Merged

build: Update Typescript #13602

merged 9 commits into from
Sep 25, 2024

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Sep 23, 2024 •
edited
Loading

Description

Update Typescript and fix new typecheck errors.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/dashboard Area: Related to the dashboard application solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/dependencies Used for issues or pull requests that are dependency updates area/text-editor labels Sep 23, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.24%. Comparing base (9bdf6e2) to head (8484ffd).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13602   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files        1502     1502           
  Lines       20582    20581    -1     
  Branches     2493     2492    -1     
=======================================
  Hits        19603    19603           
  Misses        869      869           
+ Partials      110      109    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng marked this pull request as ready for review September 23, 2024 12:54
@JamalAlabdullah JamalAlabdullah self-assigned this Sep 24, 2024
JamalAlabdullah
JamalAlabdullah approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut 👍

@JamalAlabdullah JamalAlabdullah removed their assignment Sep 24, 2024
@github-actions github-actions bot added the area/text-editor Area: Related to creating, translating and editing texts. label Sep 24, 2024
@mlqn mlqn assigned mlqn and unassigned mlqn Sep 25, 2024
@framitdavid
Copy link
Collaborator

Since this is a dev dependency, I have tested it locally and it works as expected. Tested OK.

@framitdavid framitdavid merged commit b05a627 into main Sep 25, 2024
10 checks passed
@framitdavid framitdavid deleted the update-typescript branch September 25, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@framitdavid framitdavid framitdavid approved these changes

@JamalAlabdullah JamalAlabdullah JamalAlabdullah approved these changes

Assignees
No one assigned
Labels
area/dashboard Area: Related to the dashboard application area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/text-editor Area: Related to creating, translating and editing texts. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/dependencies Used for issues or pull requests that are dependency updates solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomasEng @framitdavid @JamalAlabdullah @nkylstad @mlqn