Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unique header to dashboard #13627

Merged
merged 48 commits into from
Oct 4, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Sep 24, 2024

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 changed the title Feat add unique header to dashboard feat: add unique header to dashboard Sep 24, 2024
@github-actions github-actions bot added area/dashboard Area: Related to the dashboard application solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Sep 24, 2024
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 96.69421% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.41%. Comparing base (85a8c66) to head (5bfda26).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ges/PageLayout/DashboardHeader/DashboardHeader.tsx 94.73% 0 Missing and 2 partials ⚠️
frontend/dashboard/testing/mocks.tsx 80.00% 1 Missing ⚠️
...navigation/main-header/ProfileMenu/ProfileMenu.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13627      +/-   ##
==========================================
+ Coverage   94.38%   94.41%   +0.03%     
==========================================
  Files        1560     1573      +13     
  Lines       21176    21277     +101     
  Branches     2529     2541      +12     
==========================================
+ Hits        19986    20089     +103     
+ Misses        946      943       -3     
- Partials      244      245       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrt95 wrt95 added the frontend label Sep 24, 2024
@TomasEng TomasEng self-assigned this Sep 30, 2024
@wrt95
Copy link
Contributor Author

wrt95 commented Oct 2, 2024

Moved to block because of this PR.

@wrt95 wrt95 assigned TomasEng and unassigned wrt95 Oct 2, 2024
@wrt95 wrt95 requested a review from TomasEng October 2, 2024 13:22
@framitdavid
Copy link
Collaborator

Tested OK on localhost. :)

@framitdavid framitdavid merged commit 939464c into main Oct 4, 2024
9 checks passed
@framitdavid framitdavid deleted the feat-add-unique-header-to-dashboard branch October 4, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Area: Related to the dashboard application frontend quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants