Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct css for studioTextfieldToggleView #13630

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Sep 25, 2024

Description

Fix css that got lost after earlier adaptions on StudioTextfieldToggleView when adding more <span> elements.

PROD:
Skjermbilde 2024-09-25 kl  08 39 27

THIS BRANCH:
Skjermbilde 2024-09-25 kl  08 39 54

When used in the upload image PR, it will look like this:
Skjermbilde 2024-09-25 kl  08 47 42
Skjermbilde 2024-09-25 kl  08 47 50

Also added a gap between the icon and the text:

Skjermbilde 2024-09-25 kl  08 52 46

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 25, 2024
@standeren standeren marked this pull request as ready for review September 25, 2024 06:43
@standeren standeren force-pushed the fix/correct-css-for-studio-textfield-toggle-view branch from 5d574a5 to db1c659 Compare September 25, 2024 06:53
@mlqn mlqn self-requested a review September 25, 2024 07:00
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (fe4e468) to head (db1c659).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13630   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files        1499     1499           
  Lines       20499    20499           
  Branches     2485     2485           
=======================================
  Hits        19520    19520           
  Misses        869      869           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏

@framitdavid framitdavid merged commit 49d1da7 into main Sep 25, 2024
9 checks passed
@framitdavid framitdavid deleted the fix/correct-css-for-studio-textfield-toggle-view branch September 25, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants