Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update React I18Next #13643

Merged
merged 2 commits into from
Sep 26, 2024
Merged

build: Update React I18Next #13643

merged 2 commits into from
Sep 26, 2024

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Sep 26, 2024

Description

Updated the react-i18next NPM package. I got a lot of failing unit tests when I tried this earlier, but now everything seems to work as expected.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/dependencies Used for issues or pull requests that are dependency updates labels Sep 26, 2024
@TomasEng TomasEng force-pushed the update-react-i18next branch 2 times, most recently from bf1f9cd to 61a1f80 Compare September 26, 2024 06:39
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.24%. Comparing base (d32522e) to head (b4c59b0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13643   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files        1505     1505           
  Lines       20589    20589           
  Branches     2492     2492           
=======================================
  Hits        19611    19611           
  Misses        869      869           
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng force-pushed the update-react-i18next branch from 61a1f80 to 95e23c5 Compare September 26, 2024 06:51
@TomasEng TomasEng marked this pull request as ready for review September 26, 2024 07:05
@JamalAlabdullah JamalAlabdullah self-assigned this Sep 26, 2024
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👍

@JamalAlabdullah JamalAlabdullah removed their assignment Sep 26, 2024
@framitdavid
Copy link
Collaborator

Description

Updated the react-i18next NPM package. I got a lot of failing unit tests when I tried this earlier, but now everything seems to work as expected.

Verification

  • Your code builds clean without any errors or warnings

  • Manual testing done (required)

Wired, but good that it's working just fine now. Maybe it was som inconsistency with yarn.lock/dependencies? 😅

@framitdavid framitdavid merged commit 0425d57 into main Sep 26, 2024
9 checks passed
@framitdavid framitdavid deleted the update-react-i18next branch September 26, 2024 15:06
@TomasEng
Copy link
Contributor Author

Maybe it was som inconsistency with yarn.lock/dependencies?

Probably something like that, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend kind/dependencies Used for issues or pull requests that are dependency updates solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants