feat: add support for access packages in policy editor #13921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cess-packages-in-policy-editor-v1
…cess-packages-in-policy-editor-v1
…cess-packages-in-policy-editor-v1
…cess-packages-in-policy-editor-v1
… of https://github.com/Altinn/altinn-studio into feat/13686-support-access-packages-in-policy-editor-v1
wrt95
requested changes
Dec 18, 2024
...le/PolicyAccessPackages/PolicyAccessPackageAccordion/PolicyAccessPackageAccordion.module.css
Outdated
Show resolved
Hide resolved
...le/PolicyAccessPackages/PolicyAccessPackageAccordion/PolicyAccessPackageAccordion.module.css
Outdated
Show resolved
Hide resolved
...Rule/PolicyAccessPackages/PolicyAccessPackageAccordion/PolicyAccessPackageAccordion.test.tsx
Outdated
Show resolved
Hide resolved
...Rule/PolicyAccessPackages/PolicyAccessPackageAccordion/PolicyAccessPackageAccordion.test.tsx
Outdated
Show resolved
Hide resolved
...olicyRule/PolicyAccessPackages/PolicyAccessPackageAccordion/PolicyAccessPackageAccordion.tsx
Outdated
Show resolved
Hide resolved
...r/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/policyAccessPackageUtils.ts
Outdated
Show resolved
Hide resolved
wrt95
reviewed
Dec 18, 2024
...-editor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/AllAccessPackages.tsx
Outdated
Show resolved
Hide resolved
wrt95
reviewed
Dec 18, 2024
...itor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/ChosenAccessPackages.tsx
Outdated
Show resolved
Hide resolved
wrt95
reviewed
Dec 18, 2024
...olicyRule/PolicyAccessPackages/PolicyAccessPackageAccordion/PolicyAccessPackageAccordion.tsx
Show resolved
Hide resolved
wrt95
reviewed
Dec 18, 2024
...e/PolicyAccessPackages/PolicyAccessPackageAccordion/PolicyAccessPackageAccordionCheckbox.tsx
Outdated
Show resolved
Hide resolved
wrt95
reviewed
Dec 18, 2024
...e/PolicyAccessPackages/PolicyAccessPackageAccordion/PolicyAccessPackageAccordionCheckbox.tsx
Outdated
Show resolved
Hide resolved
wrt95
reviewed
Dec 18, 2024
...icyRule/PolicyAccessPackages/PolicyAccessPackageAccordion/PolicyAccessPackageServiceLogo.tsx
Outdated
Show resolved
Hide resolved
wrt95
reviewed
Dec 18, 2024
...PolicyRule/PolicyAccessPackages/PolicyAccessPackageAccordion/PolicyAccessPackageServices.tsx
Outdated
Show resolved
Hide resolved
wrt95
reviewed
Dec 18, 2024
...r/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/policyAccessPackageUtils.ts
Show resolved
Hide resolved
wrt95
requested changes
Dec 18, 2024
There was a problem hiding this comment.
A lot of great changes in code now 😄
We should try to add tests files for all component files and utils file so that we are sure all functionality is tested.
I understand that the code is tested through some other components, but if we need to refactor something in the future, the components cannot be dependent on other components's tests 😄
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...PolicyCardRules/PolicyRule/PolicyAccessPackages/AllAccessPackages/AllAccessPackages.test.tsx
Fixed
Show fixed
Hide fixed
… of https://github.com/Altinn/altinn-studio into feat/13686-support-access-packages-in-policy-editor-v1
wrt95
reviewed
Dec 19, 2024
...PolicyCardRules/PolicyRule/PolicyAccessPackages/AllAccessPackages/AllAccessPackages.test.tsx
Outdated
Show resolved
Hide resolved
wrt95
reviewed
Dec 19, 2024
...CardRules/PolicyRule/PolicyAccessPackages/ChosenAccessPackages/ChosenAccessPackages.test.tsx
Outdated
Show resolved
Hide resolved
wrt95
reviewed
Dec 19, 2024
...Accordion/PolicyAccessPackageAccordionCheckbox/PolicyAccessPackageAccordionCheckbox.test.tsx
Outdated
Show resolved
Hide resolved
wrt95
reviewed
Dec 19, 2024
...mponents/PolicyCardRules/PolicyRule/PolicyAccessPackages/PolicyAccordion/PolicyAccordion.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Access packages will replace Altinn roles in policy in the future. It should be possible to use both Altinn roles and access packages as policy subject
No changes in validation yet; users must still choose at least one role per rule
In resourceadm
screen-capture.webm
In app development
app_development.webm
Related Issue(s)
Verification
Documentation